-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][UPD] Update account_comment_template_report_invoice.xml #264
Conversation
b6cc446
to
522cb6a
Compare
522cb6a
to
8264e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice should have ^^
This PR has the |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cyrilmanuel can you please update your commit message to follow guidelines? |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-264-by-dreispt-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Syncing from upstream OCA/account-invoice-reporting (17.0)
Rendering of template is wrong. the base-comment-template work on the mixin of mail. this feature allow the possibilities to add {{ object }} and interpret them directly by the render_comment() function.
today, the template render the comment html directly and bypass the render function.
this update will render the comment template with interpreted value.
https://github.com/OCA/reporting-engine/blob/15.0/base_comment_template/README.rst